Don't emit useless code for zero-arg operations/constructors

Closes #34.
jsdom · Apr 29, 2017 · 4dd82b0 · 4dd82b0
1 parent c2214f1
commit 4dd82b0
Showing 1 changed file with 14 additions and 13 deletions.
diff --git a/lib/parameters.js b/lib/parameters.js
@@ -93,23 +93,24 @@ module.exports.generateOverloadConversions = function (overloads, customTypes) {
 
   const typeConversions = Overloads.proveSimiliarity(overloads);
 
-  str += `
+  const isAlwaysZeroArgs = !isVariadic && maxArguments === 0;
+  if (!isAlwaysZeroArgs) {
+    const extraClause = !isVariadic ? ` && i < ${maxArguments}` : ``;
+    str += `\n
   const args = [];
-  for (let i = 0; i < arguments.length`;
-  if (!isVariadic) {
-    str += ` && i < ${maxArguments}`;
-  }
-  str += `; ++i) {
+  for (let i = 0; i < arguments.length${extraClause}; ++i) {
     args[i] = utils.tryImplForWrapper(arguments[i]);
   }`;
-  for (let i = 0; i < typeConversions.length; ++i) {
-    if (typeConversions[i] === null) {
-      continue;
-    }
 
-    const conv = module.exports.generateVarConversion(`args[${i}]`, typeConversions[i], maxConstructor.operation.arguments[i].extAttrs, customTypes);
-    Object.assign(requires, conv.requires);
-    str += conv.body;
+    for (let i = 0; i < typeConversions.length; ++i) {
+      if (typeConversions[i] === null) {
+        continue;
+      }
+
+      const conv = module.exports.generateVarConversion(`args[${i}]`, typeConversions[i], maxConstructor.operation.arguments[i].extAttrs, customTypes);
+      Object.assign(requires, conv.requires);
+      str += conv.body;
+    }
   }
   return {
     requires,