Implement support for the [Exposed] extended attribute
#192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
TimothyGu
reviewed
Apr 4, 2020
ExE-Boss
force-pushed
the
feat/ext-atrr/exposed
branch
from
219c106
to
860200a
Compare
Co-authored-by: Timothy Gu <timothygu99@gmail.com>
Assume globalNames is an array
[ci skip]
domenic
added a commit
that referenced
this pull request
Apr 18, 2020
This reverts commit 464a43f as part of rollback to before recent breaking changes, so we can make a new v15 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #190 at @TimothyGu’s request in #191 (review).
This also fixes a bug where
installtakesglobalNameinstead ofglobalNames.This will free up #190 to only handle the creation of
webidl2js‑globals.js.