Fix legacy platform object [[Set]] operation #218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the legacy platform object
[[Set]]
operation implementation to match the WebIDL spec, which doesn’t exclude array index properties from named properties when indexed setters aren't supported.It also fixes the bug that was caused by the
receiver
argument in a Proxy trap pointing to the Proxy exotic object or an object that inherits from it, rather than to the underlying Proxy target.This can be verified with:
Which logs
false
.review?(@domenic)