allow getters, setters and deleters to be shadowed in derived class #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you add a test by dropping a file or two into https://github.com/jsdom/webidl2js/tree/master/test/cases , which fails before this change but passes after? |
|
There you go! |
Comment on lines
-216
to
-218
| if (this.namedGetter) { | ||
| throw new Error(`${msg}duplicated named getter`); | ||
| } |
There was a problem hiding this comment.
You could also change the condition to if (this.hasOwnProperty(member)) in order to keep at least a check on duplicated member names, but I noticed this kind of check is not in place for regular attributes either, so i preferred to have the same behaviour for getters and setters as well i.e. if multiple members have the same name, simply use the last defined one and discard all the others.
domenic
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#113