Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unscopeable] is now [Unscopable] #95

Merged
merged 1 commit into from
Nov 25, 2017
Merged

[Unscopeable] is now [Unscopable] #95

merged 1 commit into from
Nov 25, 2017

Conversation

Zirro
Copy link
Member

@Zirro Zirro commented Nov 25, 2017

This changed all the way back in whatwg/webidl#103.

It is a breaking change, though I doubt many will be affected.

@Zirro Zirro mentioned this pull request Nov 25, 2017
Merged
TimothyGu
TimothyGu approved these changes Nov 25, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a corresponding update in jsdom too

@TimothyGu TimothyGu merged commit a0159a3 into jsdom:master Nov 25, 2017
@Zirro
Copy link
Member Author

Zirro commented Nov 25, 2017

That update is part of jsdom/jsdom#2053.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zirro @TimothyGu