Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser field #44

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Browser field #44

merged 3 commits into from
Oct 7, 2021

Conversation

dmail
Copy link
Member

@dmail dmail commented Oct 7, 2021

No description provided.

@dmail dmail self-assigned this Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Performance impact

Impact on 5 metrics when merging browser_field into master. Before drawing conclusion, keep in mind performance variability.

@jsenv/importmap-node-module package
Metric Before merge After merge Impact
import duration 0.397 seconds 0.413 seconds +0.016 seconds / +4.03% ↗️
import memory heap used 17.24 MB 16.46 MB -792.29 KB / -4.49% ↘️
npm tarball size 81.12 KB 81.44 KB +330 B / +0.4% ↗️
npm tarball unpacked size 357.45 KB 359.11 KB +1.67 KB / +0.47% ↗️
npm tarball file count 26 26 👻
Generated by @jsenv/performance-impact during performance_impact#1316428133 on 8fdf002

@dmail dmail marked this pull request as ready for review October 7, 2021 13:44
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #44 (8fdf002) into master (ca98f5a) will increase coverage by 0.21%.
The diff coverage is 95.71%.

@dmail dmail merged commit 515b640 into master Oct 7, 2021
@dmail dmail deleted the browser_field branch October 7, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant