Performance regression

[enzadesai]

I just updated from 5.34.0 to 5.35.1 on IntelliJ IDEA 2019.3.1 Build 193.5662.53. There is a massive regression in performance, so much so that typing would get stuck for seconds (2-3s at times).

I am unsure what details (plugin logs, etc.) that would be useful here. I am also not certain if there are ways to instrument the plugin on my machine.

[jshiell]

Thanks for the report. Is 5.35.0 okay? There was a change in the thread handling for 5.35.1 to fix a deadlock with newer versions of IDEA, but this would result in coarser thread locking, and I was only able to test it on an i7 so it could well be the cause.

[jshiell]

Could you please try this pre-release of 5.35.2? This restores the background thread for the Checkstyle execution, but shuffles the file creation to try and avoid the deadlock in #462. Thank you!

(link removed as now released)

[enzadesai]

That was so fast! Been testing this for a bit and looks great! 👍🚢

[jshiell]

Luckily I'm still on holiday - thanks very much for the report, and sorry for the hassle!