Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter files from results tree #644

Closed
delanym opened this issue Jun 10, 2024 · 3 comments
Closed

Filter files from results tree #644

delanym opened this issue Jun 10, 2024 · 3 comments

Comments

@delanym
Copy link

delanym commented Jun 10, 2024

In version 5.92.0 I ran a scan on the entire project, which returned around 3000 issues. Only a handful are error level, so I make sure "Display Errors" is selected and none of the others.

image

This only has the effect of filtering the violation line, and not the file that violations were found in.
You can see in the image I need to find the angle bracket to actually locate the violation.

If there are no violations within the filter scope, the file should not be displayed in the tree.

I see now I can unfold the nodes, but still, why show me the file. If I click the violation it opens the file, and that's all I need to see.
Perhaps add a button to determine whether files are shown at all?

@jshiell
Copy link
Owner

jshiell commented Jun 30, 2024

Yeah, that definitely seems like a silly thing to show in the circumstances. I'll have a look when I get a tick - thanks!

jshiell added a commit that referenced this issue Aug 8, 2024
Note that the child count is currently hard coded and hence incorrect at present, that will take a little more tweaking to fix
@jshiell
Copy link
Owner

jshiell commented Aug 8, 2024

Basic fix is now in main; however, the trailing "x item(s)" text is incorrect and will need some further love (hence not closing this yet).

@jshiell
Copy link
Owner

jshiell commented Aug 8, 2024

Will be in the next release. Thanks for the tip!

@jshiell jshiell closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants