Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#621: Allow additional bundled configs #622

Merged
merged 2 commits into from
Sep 24, 2023
Merged

#621: Allow additional bundled configs #622

merged 2 commits into from
Sep 24, 2023

Conversation

rhierlmeier
Copy link

No description provided.

@jshiell
Copy link
Owner

jshiell commented Sep 16, 2023

Thanks very much - I'll try have a look at this when I'm back from business travel in just over a week 🤞

@rhierlmeier
Copy link
Author

Great,
what I have not done is providing a API Maven artifact for the provider interface that has to be implemented by the additional bundle configs.

@jshiell
Copy link
Owner

jshiell commented Sep 24, 2023

Thanks, this looks simple and effective. I'll get it merged so you can use it, and the Maven niceties can come later.

@jshiell jshiell merged commit 2b9fc5c into jshiell:main Sep 24, 2023
jshiell added a commit that referenced this pull request Sep 24, 2023
@rhierlmeier
Copy link
Author

Thank you for merging this PR. When is the next release planned?

Do we need some kind of documentation for this feature?

@jshiell
Copy link
Owner

jshiell commented Oct 1, 2023

It was included in the release made on the same day. Documentation would certainly be nice as well - I haven't made an effort there as yet!

@jshiell
Copy link
Owner

jshiell commented Oct 1, 2023

I added some basic instructions based on your comments in #621 in 3925513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants