Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some MS-related extensions and types #336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add some MS-related extensions and types #336

wants to merge 2 commits into from
+28 −1

Conversation

ipetrouchtchak-fi
Copy link

@ipetrouchtchak-fi ipetrouchtchak-fi commented Aug 30, 2024 •
edited
Loading

Added some missing MS-related extensions and types.
@wesleytodd, please review

@ipetrouchtchak-fi ipetrouchtchak-fi mentioned this pull request Aug 30, 2024
Open
viceice
viceice reviewed Sep 30, 2024
View reviewed changes
src/custom-types.json Outdated Show resolved Hide resolved
viceice
viceice reviewed Oct 4, 2024
View reviewed changes
Copy link

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not allowed to approve.

@ipetrouchtchak-fi
Copy link
Author

ipetrouchtchak-fi commented Oct 4, 2024 •
edited
Loading

LGTM, I'm not allowed to approve.

@wesleytodd, @bjohansebas, could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipetrouchtchak-fi @viceice