Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mjs to application/javascript #88

Closed
wants to merge 1 commit into from
Closed

Add mjs to application/javascript #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@
"source": "iana",
"charset": "UTF-8",
"compressible": true,
"extensions": ["js"]
"extensions": ["js","mjs"]
},
"application/jf2feed+json": {
"source": "iana",
Expand Down
6 changes: 5 additions & 1 deletion src/custom-types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,11 @@
},
"application/javascript": {
"charset": "UTF-8",
"compressible": true
"compressible": true,
"extensions": ["mjs"],
"sources": [
"https://github.com/nodejs/node-eps/blob/master/002-es-modules.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the mime listed on that page, though there is a link to another page saying .mjs should be type application/javascript+module

Can the page be updated to clarify what the mime is or link to a different source that does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It links to tc39/ecma262#322 which rejects the new subtype of +module and can be cross referenced in whatwg/html#558 and step 7 of https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-single-module-script . I will write up a PR and merge it for the node EP explicitly stating that it needs to be the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs/node-eps#61 is approved pending confirmation of what the preferred MIME type should be. Either text/javascript or application/javascript.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, unless it comes from one of our sources, it's standard procedure to collect this before adding to custom. It seems to have been useful, as it sounds like the act of clarifying may have changed what it is going to be. If it does end up landing as text/javascript, please feel free to update the PR and I can merge 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed any preference since standards disagree, any web compatible MIME is the main need so this looks fine.

]
},
"application/json": {
"charset": "UTF-8",
Expand Down