wip: detect aks cluster name #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
jsirianni
force-pushed
the
azure/detect-cluster-name
branch
from
78e2dab to
68dd15c
Compare
antonblock
reviewed
Nov 16, 2023
jsirianni
force-pushed
the
azure/detect-cluster-name
branch
from
125db6d to
0065a48
Compare
jsirianni
force-pushed
the
azure/detect-cluster-name
branch
from
0065a48 to
030bdc1
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added best effort support for detecting Azure Kubernetes Service cluster name:
k8s.cluster.name.The cluster name can be extracted from the cluster's "resource group name" which is retrieved using existing functionality. The
parseClusterNamefunction has comments explaining the limitations.Link to tracking Issue:
open-telemetry#26794
Testing:
I added unit tests for each scenario, and have tested against live AKS clusters that fit each scenario. I am happy to spin these up if anyone has any questions.
Documentation:
Added
k8s.cluster.nameto the list of AKS resource attributes.