Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ros-o / Ubuntu 22.04 #512

Merged
merged 17 commits into from
Dec 26, 2024
Merged

Support ros-o / Ubuntu 22.04 #512

merged 17 commits into from
Dec 26, 2024

Conversation

mqcmd196
Copy link
Member

@mqcmd196 mqcmd196 commented Nov 13, 2024 •
edited
Loading

  • [libsiftfast] support multiple python3 version
  • [sesame_ros] remove cffi which cannot be installed in Ubuntu 22.04 env & not used in sesame_ros
  • [ff] relax linker. allow function duplication
  • [ffha] relax linker. allow function duplication
  • [downward] patching to fix std::vector namespace
  • [zdepth] fix build hunging issue 2nd+ time

@mqcmd196 mqcmd196 mentioned this pull request Nov 13, 2024
Open
@v4hn v4hn mentioned this pull request Nov 18, 2024
Merged
k-okada
k-okada approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, updated with ROS-O tests

@k-okada k-okada merged commit 5d4ecc6 into jsk-ros-pkg:master Dec 26, 2024
13 checks passed
@mqcmd196 mqcmd196 deleted the ros-o branch December 27, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazeshun pazeshun pazeshun left review comments

@k-okada k-okada k-okada approved these changes

Assignees
No one assigned
Labels
collada_urdf_jsk_patch dialogflow_task_executive downward ff ffha github-action jsk_3rdparty libsiftfast respeaker_ros sesame_ros zdepth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mqcmd196 @k-okada @pazeshun