-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_tools] Add delay_timestamp.py #1216
Conversation
7a2b8d6
to
4bba134
Compare
Please merge. |
you do not have to pass msg type, see http://wiki.ros.org/topic_tools |
4bba134
to
7382a59
Compare
I updated the commit. |
by the way , when you use this tool? I though we do not need this is you crony all computers and use message filter. |
This is not for demo, but test for nodes which uses message_filters. |
@k-okada |
add ros::warn to describe this is just for test code ◉ Kei Okada On Tue, Nov 10, 2015 at 9:24 PM, Kentaro Wada notifications@github.com
|
instead of that, why don't we add doc for it? |
doc is ok, but people who use this without knowing this is designed for the ◉ Kei Okada On Tue, Nov 10, 2015 at 10:25 PM, Kentaro Wada notifications@github.com
|
what do you mean with 'the system'? 2015年11月10日火曜日、Kei Okadanotifications@github.comさんは書きました:
和田 健太郎 / Kentaro Wada |
and why do they use this node without reading doc or code? if you worry about the limited use case, we can create a new package 2015年11月10日火曜日、Kentaro Wadawww.kentaro.wada@gmail.comさんは書きました:
和田 健太郎 / Kentaro Wada |
system means everything but test code ◉ Kei Okada On Tue, Nov 10, 2015 at 10:36 PM, Kentaro Wada notifications@github.com
|
On Tue, Nov 10, 2015 at 10:40 PM, Kentaro Wada notifications@github.com
because the node exists. ◉ Kei Okada |
because the node is necessary for their system, isn't it? If so, they should read the documentation (or code). |
they somehow find the node and misinterpret the usage, I'm pretty sure that ◉ Kei Okada On Tue, Nov 10, 2015 at 10:52 PM, Kentaro Wada notifications@github.com
|
So you mean they misunderstand this as substitute for topic_tools/throttle. I think I understand your concern, and I'd like to avoid that possibility by putting it another package. could I create a new package? (jsk_test_tools) to serve nodes for test like |
people who do not read document will think this is a magic node that solves ◉ Kei Okada On Tue, Nov 10, 2015 at 11:03 PM, Kentaro Wada notifications@github.com
|
Okay. Maybe that kind of people overlook the warning message, so you say BIG ;) 2015年11月10日火曜日、Kei Okadanotifications@github.comさんは書きました:
和田 健太郎 / Kentaro Wada |
After long discussion at jsk-ros-pkg#1216
thank you |
Please merge. |
[jsk_tools] Add delay_timestamp.py
For jsk-ros-pkg/jsk_recognition#1288