Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update force_to_rename_changelog_user.py #1345

Merged
merged 1 commit into from
Feb 11, 2016
Merged

Update force_to_rename_changelog_user.py #1345

merged 1 commit into from
Feb 11, 2016

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Feb 11, 2016

https://github.com/jsk-ros-pkg/jsk_common/blob/master/jsk_tools/bin/force_to_rename_changelog_user.py#L58 checks key with lower case, if there is a way to find key with case-insensitive like (find author autohr_list :test #'(lambda (x y) (str= (lower-case x) (lower-case y))), please let me know,

            author = author.lower()
            if author in REPLACE_RULES:
                replaced_authors.append(REPLACE_RULES[author])
``

https://github.com/jsk-ros-pkg/jsk_common/blob/master/jsk_tools/bin/force_to_rename_changelog_user.py#L58 checks key with lower case, if there is a way to find key with case-insensitive like `(find author autohr_list :test #'(lambda (x y) (str= (lower-case x) (lower-case y)))`, please let me know, 
```
            author = author.lower()
            if author in REPLACE_RULES:
                replaced_authors.append(REPLACE_RULES[author])
``
k-okada added a commit that referenced this pull request Feb 11, 2016
Update force_to_rename_changelog_user.py
@k-okada k-okada merged commit b3ad375 into master Feb 11, 2016
@k-okada k-okada deleted the k-okada-patch-2 branch May 1, 2016 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant