Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to make Travis testing pass #1750

Merged
merged 4 commits into from
Jun 22, 2016
Merged

Conversation

wkentaro
Copy link
Member

@k-okada
Copy link
Member

k-okada commented Jun 20, 2016

Check ros/rosdistro#11887, this include Python deps

@wkentaro
Copy link
Member Author

Thank you. I confirmed.

@wkentaro
Copy link
Member Author

Please merge this.

@@ -1,7 +1,7 @@
- git:
uri: https://github.com/jsk-ros-pkg/jsk_common.git
local-name: jsk-ros-pkg/jsk_common
version: master
version: 2.0.16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because jsk-ros-pkg/jsk_common#1417 is not yet merged and released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought jsk_tools 2.0.16 has enough python dependency

$ sudo aptitude show ros-indigo-jsk-tools
Package: ros-indigo-jsk-tools            
State: installed
Automatically installed: no
Version: 2.0.16-1trusty-20160619-095439-0700
Priority: extra
Section: misc
Maintainer: Ryohei Ueda <ueda@jsk.t.u-tokyo.ac.jp>
Architecture: amd64
Uncompressed Size: 388 k
Depends: python-colorama, python-texttable, ros-indigo-axis-camera,
         ros-indigo-jsk-network-tools, ros-indigo-jsk-topic-tools,
         ros-indigo-pr2-computer-monitor, ros-indigo-rosbag,
         ros-indigo-rosemacs, ros-indigo-rosgraph-msgs, ros-indigo-rospy,
         ros-indigo-rqt-reconfigure
Conflicts: ros-indigo-jsk-tools

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs python-termcolor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python-termcolor is not released on saucy and will not included deb
dependency, but if you wait 1 more week, we can release new version
including python-termcolor due to terminating saucy support for indigo (
http://lists.ros.org/pipermail/ros-release/2016-June/004879.html)
$ rosdep resolve --os=ubuntu:saucy python-termcolor
#pip
termcolor

◉ Kei Okada

On Wed, Jun 22, 2016 at 4:31 PM, Kentaro Wada notifications@github.com
wrote:

In .travis.rosinstall
#1750 (comment)
:

@@ -1,7 +1,7 @@

It needs python-termcolor.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jsk-ros-pkg/jsk_recognition/pull/1750/files/81315abc27562253ac8d9191f7c2f17d2545408e#r68006114,
or mute the thread
https://github.com/notifications/unsubscribe/AAeG3LjFWCU6tI69qEuzo-VuvzUVFMr_ks5qOOS8gaJpZM4I3fwk
.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that. Do you mean you cannot merge this until that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged but please do not forget to write another PR a week later...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an issue.

@k-okada k-okada merged commit 506dbaa into jsk-ros-pkg:master Jun 22, 2016
@wkentaro wkentaro deleted the hotfix-travis branch June 22, 2016 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants