Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fetch robot localization and navigation #1147

Merged
merged 28 commits into from
Oct 27, 2019

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Oct 16, 2019

I add nodes which publish correct odom /odom_corrected and imu /imu_corrected.
Then I use these two corrected topics for robot_localization ukf for localization.
I wonder this change suppress odometry error.

now testing on fetch15.

cc. @708yamaguchi @sktometometo

related:

@knorth55 knorth55 changed the title [WIP] fix fetch robot localization fix fetch robot localization Oct 18, 2019
@knorth55 knorth55 requested a review from 708yamaguchi October 18, 2019 17:56
Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, but I am not sure if this PR works correctly.
(I do not know the effect of ukf_localization_node.)

I think that this PR can be merged if jsk_patrol demo works correctly everyday.

@knorth55
Copy link
Member Author

I'm working in go-to-kitchen first.
jsk_patrol is a bit complicated because of mail notification.
also I'm wondering if jsk_patrol totally shouldbe done in jsk_demos.

@knorth55
Copy link
Member Author

knorth55 commented Oct 19, 2019

Going kitchen demo is now working stably.
(x5 gif)
go_to_kitchen_6_gopro

Robot head camera: https://drive.google.com/open?id=1K945-KXcfUQIeGudZpfd_9qWPyd95a8w
GoPro: https://drive.google.com/open?id=1gtCfZoSeAgj8Xs1SzmjneXrwqGx6qYAH

@knorth55 knorth55 changed the title fix fetch robot localization fix fetch robot localization and navigation Oct 19, 2019
@knorth55
Copy link
Member Author

knorth55 commented Oct 19, 2019

@708yamaguchi
簡単に説明すると変更したことは、

  • graft から robot_localizationに移行したい
    • graftはもうメンテナンスされてない
    • /odomがおかしい
      • frame_idが設定されてない
      • covarianceが設定されてない(graftでoverrideされていたのでそれをodom_correctorで上書きする)
    • /imuがおかしい
      • covarianceが設定されてない (graftでoverrideされていたのでそれをimu_correctorで上書きする)
  • amclのrotationに対する不確実性をあげたい
    • odom_alphaの更新
      • 0.1 -> 0.5
  • costmapを更新してロボットがぶつからないようにしたい、車輪がすべったり、その場回転で微妙に移動したりするのでものからできるだけ離れておきたい
    • inflation_radiuscost_scaling_factorを変更する
      • できるだけ障害物から離れるパスを出すようにする
    • footprint_paddingを大きくする
      • 0.01 -> 0.05
  • local plannerがおかしい
    • dwaを有効化する
      • もともと有効化されてなかった!
      • これを有効化するとFetchのやばげな早い動きがなくなった!
  • correct_position.pyを更新する
    • covarianceを小さくする
      • dockの中なので小さくてOK
    • 1Hzでpublishする
      • dockに長時間で止まっているとずれていくので常に修正する

@knorth55
Copy link
Member Author

knorth55 commented Oct 20, 2019

NOTE: it seems that head_camera is not used for costmap observation resource... weird... why is fetch15 nodding head while moving...?
head camera is subscribed in Fetch Depth Layer by default. it was my misunderstanding.

@708yamaguchi
Copy link
Member

Thank you for robot demo and your explanation.
I think this PR can be merged.

@k-okada
Copy link
Member

k-okada commented Oct 26, 2019

failing due to missing packages https://travis-ci.org/jsk-ros-pkg/jsk_robot/jobs/602916381

  <system-out><![CDATA[[
[/home/travis/ros/ws_jsk_robot/src/jsk_robot/jsk_fetch_robot/jsk_fetch_startup/launch/fetch_gazebo_bringup.launch]:
	cannot find package [robot_localization] for node [ukf_localization_node]
unable to find node [robot_localization/ukf_localization_node]: robot_localization

@knorth55
Copy link
Member Author

@k-okada thank you! I updated.

@k-okada k-okada merged commit 67a7458 into jsk-ros-pkg:master Oct 27, 2019
@knorth55 knorth55 deleted the fetch-fix-nav branch October 27, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants