Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fetch_ros in jsk_fetch.rosinstall.indigo #1148

Merged
merged 3 commits into from
Jul 19, 2021
Merged

add fetch_ros in jsk_fetch.rosinstall.indigo #1148

merged 3 commits into from
Jul 19, 2021

Conversation

knorth55
Copy link
Member

fetch_ros is not released in Indigo, so we need to install it manually.

@knorth55 knorth55 requested a review from 708yamaguchi October 18, 2019 17:57
708yamaguchi
708yamaguchi reviewed Oct 19, 2019
View reviewed changes
Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is fetch_ros also needed in jsk_fetch_user.rosinstall.indigo?
https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_fetch_robot/jsk_fetch_user.rosinstall.indigo

Currently, jsk_fetch_user.rosinstall.kinetic includes fetch_ros.
https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_fetch_robot/jsk_fetch_user.rosinstall.kinetic#L20-L23

@knorth55 knorth55 mentioned this pull request Oct 19, 2019
Closed
29 tasks
@knorth55
Copy link
Member Author

knorth55 commented Oct 19, 2019 via email

@708yamaguchi
Copy link
Member

708yamaguchi commented Oct 20, 2019 •
edited
Loading

OK, I think this PR can be merged.

I will create another PR to include fetch_ros in jsk_fetch_user.rosinstall.indigo(kinetic).
#1153

@708yamaguchi 708yamaguchi mentioned this pull request Oct 20, 2019
Merged
@YutoUchimi YutoUchimi added this to the 1.1.1 milestone Nov 19, 2019
@k-okada k-okada requested a review from pazeshun November 25, 2019 07:47
@knorth55 knorth55 mentioned this pull request Jul 24, 2020
Closed
k-okada
k-okada reviewed Jul 16, 2021
View reviewed changes
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we already upgrade fetch internal PC, do we still need this? @708yamaguchi

@knorth55
Copy link
Member Author

I think we can keep this rosinstall in jsk_robot for historical herigate...

@k-okada
Copy link
Member

k-okada commented Jul 16, 2021

should we create jsk_fetch_robot.rosinstall.indigo?

@knorth55
Copy link
Member Author

should we create jsk_fetch_robot.rosinstall.indigo?

maybe we should create jsk_fetch_robot.rosinstall.indigo and jsk_fetch_robot.rosintall.melodic.

@knorth55 knorth55 changed the title add fetch_ros in jsk_fetch.rosinstall add fetch_ros in jsk_fetch.rosinstall.melodic Jul 16, 2021
@knorth55 knorth55 mentioned this pull request Jul 16, 2021
Merged
@k-okada
Copy link
Member

k-okada commented Jul 17, 2021

sorry I can not resolve conflicts.... @708yamaguchi

@knorth55 knorth55 changed the title add fetch_ros in jsk_fetch.rosinstall.melodic add fetch_ros in jsk_fetch.rosinstall.indigo Jul 17, 2021
@k-okada k-okada force-pushed the fetch-rosinstall branch from 61267d6 to 452a18f Compare July 19, 2021 01:31
@k-okada k-okada merged commit 411c923 into jsk-ros-pkg:master Jul 19, 2021
@knorth55 knorth55 deleted the fetch-rosinstall branch July 19, 2021 03:35
k-okada added a commit to k-okada/jsk_demos that referenced this pull request Jun 9, 2022
@k-okada
update jsk_fetch.rosinstall directory, due to jsk-ros-pkg/jsk_robot#1148
7aea130
k-okada added a commit to k-okada/jsk_demos that referenced this pull request Jun 9, 2022
@k-okada
update jsk_fetch.rosinstall directory, due to jsk-ros-pkg/jsk_robot#1148
5972c73
@knorth55 knorth55 mentioned this pull request Sep 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-okada k-okada k-okada left review comments

@708yamaguchi 708yamaguchi 708yamaguchi approved these changes

@pazeshun pazeshun Awaiting requested review from pazeshun

Assignees
No one assigned
Labels
enhancement fetch15 MergeOK NeedDiscussion
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@knorth55 @708yamaguchi @k-okada @YutoUchimi