Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fetcheus] do not set :wait-until-update in (send *ri* :state :worldcoords) #1167

Merged
merged 6 commits into from
Oct 21, 2020

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Nov 8, 2019

do not set :wait-until-update when (send *ri* :state :worldcoords).
it occurs error with fetch-interface.

@knorth55 knorth55 requested a review from 708yamaguchi November 8, 2019 14:57
@knorth55 knorth55 changed the title do not set :wait-until-update when :worldcoords [fetcheus] do not set :wait-until-update when :worldcoords Nov 8, 2019
@knorth55 knorth55 mentioned this pull request Nov 8, 2019
29 tasks
Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:state in robot-move-base-interface does not expect :wait-until-update keyword.
https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/master/pr2eus/robot-interface.l#L1716-L1724

@knorth55 knorth55 mentioned this pull request Nov 9, 2019
12 tasks
@YutoUchimi YutoUchimi added this to the 1.1.1 milestone Nov 19, 2019
@k-okada
Copy link
Member

k-okada commented Nov 25, 2019

please add test

@knorth55
Copy link
Member Author

I want to add test but waiting for pr2eus move base test.
jsk-ros-pkg/jsk_pr2eus#420

@knorth55
Copy link
Member Author

Sorry, it was my misunderstanding. I will add test.

@knorth55
Copy link
Member Author

I updated and added the test.

@knorth55
Copy link
Member Author

@k-okada I update and add a test. please merge this.

@tkmtnt7000
Copy link
Member

@k-okada Please merge this PR! we need this PR for fetch semi demo.

@k-okada k-okada merged commit f76b36b into jsk-ros-pkg:master Oct 21, 2020
@knorth55 knorth55 deleted the fix-state-worldcoords branch October 21, 2020 10:03
@knorth55 knorth55 changed the title [fetcheus] do not set :wait-until-update when :worldcoords [fetcheus] do not set :wait-until-update in (send *ri* :state :worldcoords) Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants