[fetcheus] fix ros-info in :go-pos-unsafe in fetch-interface.l #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
708yamaguchi
approved these changes
Nov 8, 2019
knorth55
changed the title
|
we should rewrite argument of This makes user to understand the API easily |
k-okada
reviewed
Nov 25, 2019
| @@ -261,7 +261,8 @@ Example: (send self :gripper :position) => 0.00" | |||
| (send self :remprop :go-pos-unsafe-no-wait-goal) | |||
|
|
|||
| ;; yaw-x-yaw approach | |||
| (ros::ros-info "go-pos-unsafe: (yaw, x, yaw) = (~A ~A ~A)" d0 d1 d2) | |||
| (ros::ros-info "go-pos-unsafe: (yaw, x, yaw) = (~A ~A ~A)" | |||
| d0 (* (if forward-p 1.0 -1.0) d1) d2) | |||
There was a problem hiding this comment.
I think this will show both
go-pos-unsafe: (x y d) = ( ...) -> (yaw x yaw) = ( ... )
and
`send-cmd-vel-raw: ....
There was a problem hiding this comment.
what are you considering about?
I dont understand what you are worrying about.
|
go-pos-unsafe takes x,y, d as argument, not yaw/x/yaw
--
◉ Kei Okada
2019年11月25日(月) 20:31 Shingo Kitagawa <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In jsk_fetch_robot/fetcheus/fetch-interface.l
<#1168 (comment)>
:
> @@ -261,7 +261,8 @@ Example: (send self :gripper :position) => 0.00"
(send self :remprop :go-pos-unsafe-no-wait-goal)
;; yaw-x-yaw approach
- (ros::ros-info "go-pos-unsafe: (yaw, x, yaw) = (~A ~A ~A)" d0 d1 d2)
+ (ros::ros-info "go-pos-unsafe: (yaw, x, yaw) = (~A ~A ~A)"
+ d0 (* (if forward-p 1.0 -1.0) d1) d2)
what are you considering about?
I dont understand what you are worrying about.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1168?email_source=notifications&email_token=AADYNXBKMDIFGAGX6RT6773QVOZRHA5CNFSM4JK5B7X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCM2I6WI#discussion_r350130300>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYNXCXEYS3BFPSYA6TTKTQVOZRHANCNFSM4JK5B7XQ>
.
|
29 tasks
|
@k-okada I haven't understand your review, but what should I change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
:go-pos-unsaferos-warnmessage.we need to consider about
forward-p