Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_robot_common] use play-sound in pr2eus/speak.l for unsafe_warning.l #1224

Merged
merged 4 commits into from
Jul 17, 2021
Merged

[jsk_robot_common] use play-sound in pr2eus/speak.l for unsafe_warning.l #1224

merged 4 commits into from
Jul 17, 2021

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Jun 24, 2020 •
edited
Loading

UPDATE:

we switch to use play-sound in pr2eus/speak.l.
this is because it supports :volume field bug in SoundRequest.

related: jsk-ros-pkg/jsk_pr2eus#379

@knorth55 knorth55 requested a review from iory June 24, 2020 06:39
iory
iory reviewed Jun 24, 2020
View reviewed changes
Copy link
Member

@iory iory left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

play_sound is a duplication(or inferior version) of play-sound function in pr2eus/speak.l.
How about using play-sound instead of play_sound?

@knorth55
Copy link
Member Author

@iory thank you for your comment. I will update it.

@knorth55 knorth55 changed the title [jsk_robot_common] add volume in unsafe_warning.l [jsk_robot_common] use play-sound in pr2eus/speak.l for unsafe_warning.l Jun 24, 2020
@knorth55
Copy link
Member Author

@iory I updated this PR to use pr2eus/speak.l

@knorth55 knorth55 force-pushed the volume-unsafe-warning branch from 225a9f7 to b26e162 Compare June 24, 2020 14:06
@knorth55 knorth55 mentioned this pull request Jun 24, 2020
Closed
29 tasks
@iory
Copy link
Member

iory commented Jun 24, 2020

LGTM!

@knorth55 knorth55 mentioned this pull request Jul 24, 2020
Closed
@knorth55 knorth55 added this to the 1.1.1 milestone Oct 21, 2020
@k-okada k-okada merged commit 200554b into jsk-ros-pkg:master Jul 17, 2021
@knorth55 knorth55 deleted the volume-unsafe-warning branch July 17, 2021 03:35
@knorth55 knorth55 mentioned this pull request Sep 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iory iory iory approved these changes

Assignees
No one assigned
Labels
bugfix fetch15 PR1040
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@knorth55 @iory @k-okada