Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[merge after #1383] add realsense support and enable T265 odometry #1371

Merged
merged 32 commits into from
Sep 22, 2021

Conversation

sktometometo
Copy link
Contributor

@sktometometo sktometometo commented Jul 20, 2021

depends on #1205 and #1208
depends on #1383

Support Realsense cameras on base_camera_mount and support visual odometry from T265.

cc. @knorth55 @708yamaguchi

knorth55 and others added 26 commits September 19, 2021 23:50
…s, enable it to switch from secondary topics to primary topic back again)
* [jsk_fetch_startup] copy nodelet.launch.xml from realsense2_camera

* [jsk_fetch_startup] make realsense nodelet be launched as a standalone node

* [jsk_fetch_startup] change required arg of realsense_nodelet.launch.xml to respawn arg

* [jsk_fetch_startup] update fetch_reansense_bringup.launch so that it uses realsense_nodelet.launch.xml in jsk_fetch_startup instead of nodelet.launch.xml in realsense2_camera

* [jsk_fetch_startup] fix arguments for realsense bringup launch
@knorth55 knorth55 force-pushed the PR/fetch/enable-t265-odometry branch from 2dbc244 to a3b4082 Compare September 19, 2021 15:06
@knorth55 knorth55 changed the title [merge after #1205, #1208] add realsense support and enable T265 odometry add realsense support and enable T265 odometry Sep 19, 2021
@knorth55
Copy link
Member

now this PR does not depend on #1205 and #1208

@knorth55
Copy link
Member

@sktometometo can you check if this is correct?

@sktometometo
Copy link
Contributor Author

What is changed?

@knorth55
Copy link
Member

I tried rebasing, but can you check if my rebasing is correct?

@sktometometo
Copy link
Contributor Author

@knorth55 @k-okada I can't approve this PR becaust I am the author of this PR. But changes after rebasing looks fine.

@knorth55
Copy link
Member

@sktometometo thank you for checking!

@knorth55 knorth55 changed the title add realsense support and enable T265 odometry [merge after #1383] add realsense support and enable T265 odometry Sep 21, 2021
@k-okada
Copy link
Member

k-okada commented Sep 21, 2021

@sktometometo please resolve conflicts

@k-okada k-okada merged commit d8d655c into jsk-ros-pkg:master Sep 22, 2021
@sktometometo sktometometo deleted the PR/fetch/enable-t265-odometry branch September 22, 2021 02:47
k-okada added a commit that referenced this pull request Sep 25, 2021
[merge after #1208 and #1371] Fetch melodic and new hardware support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants