-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enr_message_board capability to kitchen demo #1830
Merged
sktometometo
merged 8 commits into
jsk-ros-pkg:develop/fetch
from
sktometometo:dev/add-enr-message-board-test
Jun 27, 2023
Merged
Add enr_message_board capability to kitchen demo #1830
sktometometo
merged 8 commits into
jsk-ros-pkg:develop/fetch
from
sktometometo:dev/add-enr-message-board-test
Jun 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkmtnt7000
reviewed
Jun 27, 2023
add package existence check for esp_now_ros Co-authored-by: Naoto Tsukamoto <naototukka0413@gmail.com>
tkmtnt7000
previously approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating. Nice feature.
@tkmtnt7000 Sorry, could you review this again? |
tkmtnt7000
approved these changes
Jun 27, 2023
tkmtnt7000
added a commit
that referenced
this pull request
Oct 31, 2023
* [jsk_fetch_startup] add write-message-on-message-board to navigation-utils.l * [jsk_fetch_startup] Use write-message-on-message-board in kitchen-demo * Update jsk_fetch_robot/jsk_fetch_startup/euslisp/navigation-utils.l add package existence check for esp_now_ros Co-authored-by: Naoto Tsukamoto <naototukka0413@gmail.com> * [jsk_fetch_startup] publish dummy packet before write message on message board * Add more message and debug output * [jsk_fetch_startup] fix error * [jsk_fetch_starup] get rid of dummy message writing * [jsk_fetch_startup] Change enr_message_board address --------- Co-authored-by: Naoto Tsukamoto <naototukka0413@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add enr_message_board feature to kitchen demo's trashcan capacity checking.
With this PR, Fetch write a message about trashcan occupancy to enr_message_board.
For string - byte array conversion, see euslisp/jskeus#635 for detail.