Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enr_message_board capability to kitchen demo #1830

Conversation

sktometometo
Copy link
Contributor

@sktometometo sktometometo commented Jun 27, 2023

Add enr_message_board feature to kitchen demo's trashcan capacity checking.

IMG_20230627_171251

With this PR, Fetch write a message about trashcan occupancy to enr_message_board.

For string - byte array conversion, see euslisp/jskeus#635 for detail.

add package existence check for esp_now_ros

Co-authored-by: Naoto Tsukamoto <naototukka0413@gmail.com>
tkmtnt7000
tkmtnt7000 previously approved these changes Jun 27, 2023
Copy link
Member

@tkmtnt7000 tkmtnt7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating. Nice feature.

@tkmtnt7000 tkmtnt7000 dismissed their stale review June 27, 2023 07:58

Update after approval

@sktometometo sktometometo requested a review from tkmtnt7000 June 27, 2023 08:11
@sktometometo
Copy link
Contributor Author

@tkmtnt7000 Sorry, could you review this again?

@sktometometo sktometometo merged commit f5c8210 into jsk-ros-pkg:develop/fetch Jun 27, 2023
@sktometometo sktometometo deleted the dev/add-enr-message-board-test branch June 27, 2023 08:16
tkmtnt7000 added a commit that referenced this pull request Oct 31, 2023
* [jsk_fetch_startup] add write-message-on-message-board to
navigation-utils.l

* [jsk_fetch_startup] Use write-message-on-message-board in kitchen-demo

* Update jsk_fetch_robot/jsk_fetch_startup/euslisp/navigation-utils.l

add package existence check for esp_now_ros

Co-authored-by: Naoto Tsukamoto <naototukka0413@gmail.com>

* [jsk_fetch_startup] publish dummy packet before write message on message board

* Add more message and debug output

* [jsk_fetch_startup] fix error

* [jsk_fetch_starup] get rid of dummy message writing

* [jsk_fetch_startup] Change enr_message_board address

---------

Co-authored-by: Naoto Tsukamoto <naototukka0413@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants