Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_pr2_startup] respawn speech_to_text #1926

Conversation

mqcmd196
Copy link
Member

@mqcmd196 mqcmd196 commented Dec 4, 2024

No description provided.

@Kanazawanaoaki
Copy link
Contributor

Thanks!
Looks good to me, but I'd like to do some verification on the actual robot, such as plugging and unplugging the respeaker, before merging.

Copy link
Contributor

@Kanazawanaoaki Kanazawanaoaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my own testing, I didn't see the phenomenon where speech_to_text dies after respeaker_node dies, but I think it's fine since {speech_to_text{ respawns normally.

log

20241209_respeaker_test.mp4

While pinging the two nodes, I first physically unplugged the respeaker and observed the progress.
The speech_to_text node did not die naturally, so I killed it and confirmed that it respawned.
I plugged the respeaker back in and confirmed that speech recognition was performed.

@Kanazawanaoaki Kanazawanaoaki merged commit 7074ea1 into jsk-ros-pkg:develop/pr2-noetic Dec 10, 2024
4 of 8 checks passed
@mqcmd196 mqcmd196 deleted the PR/pr2_respawn_speech_to_text branch December 10, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants