Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve Helm chart #60

Merged
merged 2 commits into from
May 10, 2024
Merged

feat: improve Helm chart #60

merged 2 commits into from
May 10, 2024

Conversation

Trojan295
Copy link
Contributor

This change is opinionated and unfortunately is a breaking change. Feel free to close the PR, if you don't like it.

Changes:

  • Adds options to specify externalIPs for the Service. Useful in case you don't have a load balancer.
  • Adds to provide an existing Secret with password. Useful if you use sealed-secrets or external-secrets.
  • Refactors the structure of values. Moves service related keys under service key, image related keys under image and puts server configuration related values under config.

It also resolves #54

@jsknnr jsknnr merged commit a8ecd25 into jsknnr:main May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsknnr jsknnr jsknnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement Request: Add Custom Annotation Option for Service
2 participants
@Trojan295 @jsknnr