Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dependencies in the gemspec. #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phiggins
Copy link

After adding this gem to a project, I noticed some weirdness around its dependencies:

  • It depends on both nokogiri-happymapper and happymapper, but does not appear to use the latter. This has the unfortunate side effect of also making downstream projects pull in an build nokogiri and libxml-ruby.
  • It lists crack as a runtime dependency, when it is only used in the project's own tests.
  • It lists multiple versions of nokogiri.

This pull request cleans up the gemspec to deal with these issues. I am not familiar with jeweler at all, so I used their Rakefile and Gemfile as guides and could have messed something up.

This is what the dependency portion of the gemspec look like in current release (1.5.10):

      s.add_runtime_dependency(%q<rest-client>, ["~> 1.6.0"])
      s.add_runtime_dependency(%q<nokogiri-happymapper>, [">= 0.5.4"])
      s.add_runtime_dependency(%q<builder>, [">= 0"])
      s.add_runtime_dependency(%q<nokogiri>, [">= 1.5.5"])
      s.add_runtime_dependency(%q<crack>, [">= 0"])
      s.add_runtime_dependency(%q<rest-client>, ["~> 1.6.0"])
      s.add_runtime_dependency(%q<happymapper>, [">= 0.3.2"])
      s.add_runtime_dependency(%q<builder>, [">= 0"])
      s.add_runtime_dependency(%q<nokogiri>, [">= 1.4.3"])
      s.add_development_dependency(%q<rspec>, [">= 0"])
      s.add_development_dependency(%q<bundler>, ["~> 1.0.12"])
      s.add_development_dependency(%q<jeweler>, [">= 0"])
      s.add_development_dependency(%q<stale_fish>, ["~> 1.3.0"])

This is what the dependencies look like with this patch applied:

      s.add_runtime_dependency(%q<rest-client>, ["~> 1.6.0"])
      s.add_runtime_dependency(%q<nokogiri-happymapper>, [">= 0.5.4"])
      s.add_runtime_dependency(%q<builder>, [">= 0"])
      s.add_runtime_dependency(%q<nokogiri>, [">= 1.5.5"])
      s.add_development_dependency(%q<rspec>, [">= 0"])
      s.add_development_dependency(%q<rake>, [">= 0"])
      s.add_development_dependency(%q<jeweler>, [">= 0"])
      s.add_development_dependency(%q<stale_fish>, ["~> 1.3.2"])
      s.add_development_dependency(%q<autotest>, [">= 0"])
      s.add_development_dependency(%q<crack>, [">= 0"])

@phiggins
Copy link
Author

It looks like this overlaps a bit with #73 and #62, hopefully this PR will fix those issues as well.

@phiggins
Copy link
Author

Any chance this could be merged?

@jasonnoble
Copy link
Collaborator

@phiggins Can you rebase this off the latest master and update this PR?

@phiggins
Copy link
Author

phiggins commented Sep 6, 2013

@jasonnoble Done.

@johanneswuerbach
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants