Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to use assertSoftly in all tests #116

Merged
merged 8 commits into from
Jan 10, 2023

Conversation

satou-aaaaa
Copy link
Contributor

Changed so that tests are not interrupted when they fail.
(If you agree, I will try to apply it to other test codes.)

@doyaaaaaken
Copy link
Collaborator

Thanks @satou-aaaaa , I agree with your opinion! 😄

@satou-aaaaa satou-aaaaa changed the title change to use assertSoftly in CsvReaderTest change to use assertSoftly in all tests Jan 10, 2023
@satou-aaaaa
Copy link
Contributor Author

@doyaaaaaken
Please review again as I have changed the scope.

@doyaaaaaken doyaaaaaken merged commit 8281219 into jsoizo:master Jan 10, 2023
@doyaaaaaken
Copy link
Collaborator

@satou-aaaaa Thanks for the good fix!

@satou-aaaaa satou-aaaaa deleted the chore/change-to-assertSoftly branch January 10, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants