Don't crash on empty query string parameter name #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1484 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 344 344
Lines 11002 11003 +1
Branches 1804 1805 +1
=======================================
+ Hits 9984 9985 +1
Misses 669 669
Partials 349 349 ☔ View full report in Codecov by Sentry. |
bkoelman
reviewed
Feb 26, 2024
bkoelman
requested changes
Feb 26, 2024
test/JsonApiDotNetCoreTests/IntegrationTests/QueryStrings/QueryStringTests.cs
Outdated
Show resolved
Hide resolved
test/JsonApiDotNetCoreTests/IntegrationTests/QueryStrings/QueryStringTests.cs
Outdated
Show resolved
Hide resolved
|
Please update to the latest master. |
verdie-g
force-pushed
the
1480-fix-empty-param
branch
from
ed78c12
to
a6c2e17
Compare
bkoelman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1480
QUALITY CHECKLIST