Controller attribute changes #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equired] so OpenAPI can determine whether parameters are required
bkoelman
force-pushed
the
controllers-frombody-required
branch
from
17db888
to
6fec255
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1503 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 346 346
Lines 11044 11044
Branches 1813 1813
=======================================
Hits 10026 10026
Misses 669 669
Partials 349 349 ☔ View full report in Codecov by Sentry. |
bkoelman
added a commit
that referenced
this pull request
Mar 16, 2024
…most of the previous PR (#1503). It turns out ASP.NET ModelState doesn't look at attributes on base parameters
bkoelman
added a commit
that referenced
this pull request
Mar 16, 2024
… most of the previous PR (#1503). It turns out that ASP.NET ModelState doesn't look at attributes on base parameters
This was referenced Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unneeded
[FromBody]from overridden controller methods, add[Required]so OpenAPI can determine whether parameters are required.QUALITY CHECKLIST