Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-target against .NET 9 RC2 #1550

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Multi-target against .NET 9 RC2 #1550

wants to merge 2 commits into from

Conversation

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (55f671c) to head (45490a7).

Files with missing lines Patch % Lines
src/Examples/DapperExample/Program.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1550   +/-   ##
=======================================
  Coverage   90.73%   90.74%           
=======================================
  Files         353      353           
  Lines       11492    11493    +1     
  Branches     1888     1888           
=======================================
+ Hits        10427    10429    +2     
- Misses        696      697    +1     
+ Partials      369      367    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman changed the title Try previews of .NET/EF 9 Try .NET/EF 9 RC1 Sep 20, 2024
@bkoelman bkoelman force-pushed the dotnet9-preview branch 4 times, most recently from 6da1d24 to 2bec731 Compare September 25, 2024 02:30
@bkoelman bkoelman force-pushed the dotnet9-preview branch 3 times, most recently from e1aa16a to c5d0800 Compare October 12, 2024 10:27
@wayne-o
Copy link
Contributor

wayne-o commented Oct 14, 2024

Hi - is there a preview Nuget of this anywhere we can try against our own code?

@bkoelman
Copy link
Member Author

bkoelman commented Oct 14, 2024

I don't think there's a need for that. EF Core 9 targets .NET 8, so the current JADNC version should work already with EF Core 9 on both .NET 8 and 9.

@bkoelman bkoelman changed the title Try .NET/EF 9 RC1 Try .NET/EF 9 RC2 Oct 14, 2024
@bkoelman
Copy link
Member Author

I've created #1619 to verify all tests are green when running on .NET 9 RC2 with EF Core 9 RC2, while still referencing JADNC that targets only .NET 8 and 6.

While there are breaking changes in the EF Core driver API (so you'll need matching versions for PostgreSQL, MySQL, SQL Server, etc.), it appears that JADNC itself is already compatible. This means we don't need to release a new version of JADNC when .NET 9 ships.

@bkoelman bkoelman force-pushed the dotnet9-preview branch 3 times, most recently from 4a11709 to 8b76268 Compare October 16, 2024 09:20
@bkoelman bkoelman changed the title Try .NET/EF 9 RC2 Multi-target against .NET 9 RC2 Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants