Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: return empty object instead of data:null in operation results #1564

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

bkoelman
Copy link
Member

According to the spec at https://jsonapi.org/ext/atomic/:

An empty result object ({}) is acceptable for operations that are not required to return data.

This PR changes the response to align with the spec by returning an empty object instead of { "data": null }.

QUALITY CHECKLIST

@bkoelman bkoelman force-pushed the fix-operations-empty-result branch from 649cce7 to 81b82ad Compare June 19, 2024 03:48
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.81%. Comparing base (0941d7c) to head (81b82ad).

Files Patch % Lines
...ation/JsonConverters/WriteOnlyDocumentConverter.cs 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1564      +/-   ##
==========================================
- Coverage   90.83%   90.81%   -0.02%     
==========================================
  Files         348      348              
  Lines       11158    11168      +10     
  Branches     1828     1831       +3     
==========================================
+ Hits        10135    10142       +7     
- Misses        673      675       +2     
- Partials      350      351       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review June 19, 2024 04:30
@bkoelman bkoelman merged commit 5583e4d into master Jun 19, 2024
16 checks passed
@bkoelman bkoelman deleted the fix-operations-empty-result branch June 19, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant