Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Do not allow the use of 'lid' when client-generated IDs are required #1581

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

bkoelman
Copy link
Member

Fixes #1574.

QUALITY CHECKLIST

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.83%. Comparing base (491b003) to head (7302906).

Files Patch % Lines
...n/Request/Adapters/ResourceIdentityRequirements.cs 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1581      +/-   ##
==========================================
+ Coverage   90.81%   90.83%   +0.01%     
==========================================
  Files         348      348              
  Lines       11168    11180      +12     
  Branches     1831     1835       +4     
==========================================
+ Hits        10142    10155      +13     
+ Misses        675      673       -2     
- Partials      351      352       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review June 30, 2024 12:15
@bkoelman bkoelman merged commit 479066f into master Jun 30, 2024
16 checks passed
@bkoelman bkoelman deleted the block-lid-on-required-client-id branch June 30, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Operations: Create resource allows lid when ClientIdGenerationMode = Required
1 participant