test single label hostnames #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC1123 allows single label hostnames with hyphens in between and starting with a digit. Signed-off-by: Stephan Wurm <stephan.wurm@a-eberle.de>
Julian
reviewed
Sep 14, 2023
Julian
reviewed
Sep 14, 2023
Signed-off-by: Stephan Wurm <stephan.wurm@a-eberle.de>
Both, RFC1034 and RFC1123, allow hostnames with digits in between and at the end. Signed-off-by: Stephan Wurm <stephan.wurm@a-eberle.de>
Drafts 4, 6, and 7 are referencing RFC1034, which, in contrast to RFC1123, does not allow a starting digit in hostnames. Signed-off-by: Stephan Wurm <stephan.wurm@a-eberle.de>
swaeberle
changed the title
This was referenced Sep 15, 2023
Drafts 4, 6, and 7 are based on RFC1034, not allowing a leading digit in hostnames. This was extended only later by newer drafts referencing RFC1123. Removed the checks for leading digit in hostnames from the older drafts, as strict checking with the old format could break existing setups. Signed-off-by: Stephan Wurm <stephan.wurm@a-eberle.de>
|
Great, thanks for the PR! |
|
Sorry, I meant to comment this before as well but it seems I forgot to (so we can move this to another issue if need be) -- we also need to address adding tests to the idn-hostname format, which also allows these! |
|
@swaeberle #686 if you're interested in helping there too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC1123 allows single label hostnames with hyphens in between and starting with a digit.