Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type of output to getName function #7

Closed
wants to merge 1 commit into from

Conversation

dbritto-dev
Copy link
Contributor

No description provided.

@jsoumelidis
Copy link
Owner

Thank you @danilobrinu for your suggestion, but this extension and the examples should remain compatible with php v5.6 which does not support return types. The newline at the end of file is correct though :)

@dbritto-dev
Copy link
Contributor Author

@jsoumelidis for PHP 7.2 and more you need the type if not you get and exception. I'm working in a project using PHP 7.2.11.

@jsoumelidis
Copy link
Owner

You're right. Extension explicitly declares the return type of the function since v7.0.x-dev. So this PR should target branch 7.0.x-dev in order this patch to applied to all 7.x.x-dev and master, of course.

@jsoumelidis
Copy link
Owner

jsoumelidis commented Jan 31, 2019

@danilobrinu please also note that if your projects uses php 7.2.x then you should use the 7.2.x-dev branch of the extension. Branch master targets php 7.3 (soon php 7.4) and won't work for 7.2 'cause of some php internal api changes.

@jsoumelidis
Copy link
Owner

See #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants