Allow messageSupplier to be null.
#105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs at best indirectly imply that it can be `null`: They have a `@throws NullPointerException` clause that mentions only the case in which `obj` is `null`, without saying anything similar about `messageSupplier`. But of course I'm actually going mostly off the implementation.... (Note that this PR is separate from #104, which describes *another* change that we could make to this parameter.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs at best indirectly imply that it can be
null: They have a@throws NullPointerExceptionclause that mentions only the case inwhich
objisnull, without saying anything similar aboutmessageSupplier.But of course I'm actually going mostly off the implementation....
(Note that this PR is separate from
#104, which describes another
change that we could make to this parameter.)