feat: reinstate trace install #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
trace-install-redux
branch
from
60f9bbb
to
1b7476a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reinstates
generator.traceInstall, instead of the recently attemptedgenerator.pinname change.traceInstallis then updated to always install traces into top-level imports rather than scopes, so it behaves like a full local install operator as opposed to making scopes that might be orphaned later on.traceInstalleffectively stops on bare specifiers, moving to scoped installs after that. This makes it useful for both adding local mappings (eggenerator.traceInstall('#local')to add a local package.json "imports" map), and external (generator.traceInstall('https://site.com/external.js')- still populating"imports").Since
htmlInjectuses this internally this then fully matches the expectations of HTML tracing as well.