Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error and add typedoc build step. #12

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

Bubblyworld
Copy link
Contributor

There's currently a type error in map.ts as none of the build steps do type
checking at the moment:

Error: node_modules/@jspm/import-map/src/map.ts:40:5 - error TS2322: Type 'URL | { map?: IImportMap; mapUrl?: string | URL; rootUrl?: string | URL; }' is not assignable to type 'URL'.
  Type '{ map?: IImportMap; mapUrl?: string | URL; rootUrl?: string | URL; }' is missing the following properties from type 'URL': hash, host, hostname, href, and 9 more.

40     this.mapUrl = mapUrl;
       ~~~~~~~~~~~

I've added a typedocs build step which does checking, so we should be able to
build docs upstream for the jspm generator and CLI now.

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2023

CLA assistant check
All committers have signed the CLA.

@Bubblyworld
Copy link
Contributor Author

Typedocs are pretty!

Screenshot 2023-02-07 at 09 30 25

@guybedford
Copy link
Member

Great to see, thank you!

@guybedford guybedford merged commit 880c2e2 into jspm:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants