-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature - convert to Hash #2
Conversation
- Added usage example in README - Added a changelog file - Bump version Signed-off-by: SteveBenner <sbenner9@gmail.com>
- added Hashugar#to_s for pretty structured output
- replaced rvm ruby version file with chruby ruby version file - added Hashugar#to_s for pretty structured output - added TODO's for future plans for this project - taking over completely from previous maintainer, as it appears he is not in contact, and Hashugar is becoming it's own beast anyway with all of my modifications
…uses a default of empty `Hash` - removed old TODO file - modified license to reflect ownership of project - bump version - TODO: cleanup Rakefile
…S`, a Struct with custom behavior - added capability of `Hashugar` to enable translation of all hyphens in Hash keys into underscores via runtime method replacement - todo: look into privacy of `stringify_keys` and see if we can't tighten things up a bit more - removed files in `/vendor/` recursively from cached index (what where they doing in there...)
- Now returns a Hash of the options, instead of Struct inspect string - Added the actual setter element of `Hashugar::OPTIONS.dehyphenate_keys` (whoops!)
- updated to version 0.0.12, which includes new methods `Hashugar#update` and `Hashugar::[]`.
…ME and documentation - removed significant code, slimming down the `Hashugar` class - updated gemspec - updated license - updated README and CHANGELOG - bumped version
Oof... Embarrassing, but a what a great example of how NOT to Open Source 🤣 I don't even recall making this request, but apparently back in my noob days I thought it was acceptable to merge my monstrous 18-commit mutation of this lib into trunk LOL. |
@SteveBenner this was completely unnecessary. This is not how opensource works. I have no obligation to accept and support code from pull requests. I am sorry that I didn't respond sooner though. |
I'm not sure what you mean by this, would you mind clarifying? I personally have several major issues with this pull request--not only does it massively re-write the library to my own whim, it's actually atrocious on many accounts.
As the author, I felt it was absolutely necessary to remove.
I'm aware of this... Realize that this was in start of my (self-taught) career, and I was clueless about software development 🙃. Now that I am versed in methodologies/protocols for contributing useful and quality code patches, I look forward to submitting some proper feature requests... |
to_new_hash
for deep conversion of a object to a regular RubyHash
README.md
(I'll add more examples most likely)CHANGELOG.md
Signed-off-by: SteveBenner sbenner9@gmail.com