Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WCAG guidelines to rule documentation #719

Merged
merged 2 commits into from
Jul 5, 2020

Conversation

backwardok
Copy link
Collaborator

@backwardok backwardok commented Jun 27, 2020

Adds in a section for every rule that specifies what the WCAG guidelines are (if applicable) in a new Accessibility guidelines section near the bottom of the rule documentation.

Additional changes:

  • Move Resources/References underneath Accessibility guidelines section
  • Fix up heading level of Resources so that the heading order progresses sequentially
  • Fix up resource link text to be clearer
  • Fix up some broken links or old references
  • Update pronoun usage in accessible-emoji to use they instead of he/she
  • Add some additional examples and rule clarity to click-events-have-key-events
  • Fix up code formatting for tabindex-no-positive
  • Add additional resources to some rules without resources
  • Change Resources from ordered list to unordered list since the order really doesn't matter

Partially addresses #30

@backwardok
Copy link
Collaborator Author

@jessebeach @WilcoFiers would love your eyes on this to validate the content I added, especially around whether the WCAG criteria I added are the appropriate criteria

@backwardok backwardok force-pushed the add-wcag branch 2 times, most recently from 1a13a3d to c1436ae Compare June 27, 2020 01:58
Adds in a section for every rule that specifies what the WCAG guidelines are (if applicable) in a new Accessibility guidelines section near the bottom of the rule documentation.

Additional changes:
- Move Resources/References underneath Accessibility guidelines section
- Fix up heading level of Resources so that the heading order progresses sequentially
- Fix up resource link text to be clearer
- Fix up some broken links or old references
- Update pronoun usage in `accessible-emoji` to use they instead of he/she
- Add some additional examples and rule clarity to `click-events-have-key-events`
- Fix up code formatting for `tabindex-no-positive`
- Add additional resources to some rules without resources
- Change Resources from ordered list to unordered list since the order really doesn't matter

Partially addresses jsx-eslint#30
@ljharb ljharb requested a review from jessebeach June 27, 2020 04:18
@jessebeach
Copy link
Collaborator

Hi @backwardok !!! Thank you for these improvements!!

@jessebeach jessebeach merged commit 592c2cc into jsx-eslint:master Jul 5, 2020
@backwardok backwardok deleted the add-wcag branch July 5, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants