Adds translations directory, Spanish README -- linked in original README #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ari-os310 thanks! my intention is that the Spanish translation would be in your master branch, and that this PR would only contain b798c68, but would link to your forked repo instead of leaving the translation inlined in this repo. |
ljharb
approved these changes
Sep 10, 2020
ljharb
force-pushed
the
translations-spanish
branch
from
b503f02 to
f702f62
Compare
|
Thank you @ljharb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not 'resolve' issue #726, but I had commented to @ljharb about adding a Spanish translation for readme
I think I have properly linked in the original readme. If anything is not best practice, I'm happy to fix