Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add export default instead of module.exports #861

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

V2dha
Copy link
Contributor

@V2dha V2dha commented Jun 23, 2022

add export default instead of module.exports in the boilerplate for rule.js to avoid Cannot use import declarations in modules that export using CommonJS errors as mentioned in the issue #772

add `export default` instead of `module.exports` to avoid `Cannot use import declarations in modules that export using CommonJS` errors
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #861 (832cbd6) into main (8c1df4d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #861   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          98       98           
  Lines        1474     1474           
  Branches      482      482           
=======================================
  Hits         1463     1463           
  Misses         11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1df4d...832cbd6. Read the comment docs.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, good catch.

@ljharb
Copy link
Member

ljharb commented Jun 23, 2022

(this was missed in #819)

@ljharb ljharb merged commit 832cbd6 into jsx-eslint:main Jun 23, 2022
@V2dha V2dha deleted the update-boilerplate branch June 23, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants