-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] img-redundant-alt
: fixed multibyte character support
#970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll need import includes from 'array-includes';
rather than .includes
but otherwise this looks great!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
=======================================
Coverage 99.01% 99.02%
=======================================
Files 105 105
Lines 1628 1634 +6
Branches 578 579 +1
=======================================
+ Hits 1612 1618 +6
Misses 16 16 ☔ View full report in Codecov by Sentry. |
img-redundant-alt
: fixed multibyte character support
@makotot hm, i rebased this and fixed one of the |
nvm, i think i figured it out |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Didn't reply due to sleep time. Thanks 🙌 |
Fixes #969.
Is it possible to replace the word boundary
\b
with\s+
? Although it has passed unit tests.Also, it seemed more natural not to check word boundaries for multibyte characters, which may be a difficult point to handle also related to #417.
(?!{)
is removed because there is no difference in the unit test results whether it is there or not.