Changed warnings in no-deprecated rule, deprecated old lifecycle me…

…thods in favor of `UNSAFE_*`
jsx-eslint · Apr 2, 2018 · 3a8b365 · 3a8b365
1 parent 8d9ba75
commit 3a8b365
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 21 deletions.
diff --git a/lib/rules/no-deprecated.js b/lib/rules/no-deprecated.js
@@ -79,17 +79,17 @@ module.exports = {
       // 16.3.0
       deprecated.componentWillMount = [
         '16.3.0',
-        'constructor',
+        'UNSAFE_componentWillMount',
         'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
       ];
       deprecated.componentWillReceiveProps = [
         '16.3.0',
-        'getDerivedStateFromProps',
+        'UNSAFE_componentWillReceiveProps',
         'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
       ];
       deprecated.componentWillUpdate = [
         '16.3.0',
-        'getDerivedStateFromProps',
+        'UNSAFE_componentWillUpdate',
         'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
       ];
       return deprecated;

diff --git a/tests/lib/rules/no-deprecated.js b/tests/lib/rules/no-deprecated.js
@@ -221,18 +221,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }
@@ -251,18 +251,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }
@@ -279,18 +279,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }
@@ -307,18 +307,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }
@@ -335,18 +335,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }
@@ -363,18 +363,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }