Roadmap v6.0.0 #686

yannickcr · 2016-07-17T23:55:26Z

So here's what I have in mind for now:

Add ESLint as a peerDependency (PR bumps deps; peerDeps allows ESLint 2 or 3 #657)
Add all configuration (Enable all rules #674, PR Add in an "all" config #683)
Remove deprecated jsx-sort-prop-types rule (Remove deprecated jsx-sort-prop-types rule? #549)
Remove rules deprecated options (like https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-deprecated.md) (PR Remove rules deprecated options #700)
Rename some JSX-specific rules to include jsx- prefix (keep old rules with a warning like jsx-sort-prop-types) (Rename some JSX-specific rules to include "jsx-" prefix #668, PR Rename some JSX-specific rules to include jsx- prefix #689)
Add findDOMNode() warning rule (Rule proposal: warn against using findDOMNode() #678)
Enable allow-in-func mode by default in no-did-mount-set-state and no-did-update-set-state rules (PR Enable allow-in-func mode by default in no-did-mount-set-state and no-did-update-set-state rules #702)
Solve recommended configuration discussions and update it accordingly (PR Remove no-danger from recommended rules #636, consider removing no-did-mount-set-state from recommended rules #596)
Support ESLint 3 and new rule format (Support ESLint 3 and new rule format #661, PR Switch to new eslint rule format (Fixes #661) #699)

Do you see anything else that could be good to change/improve?

The text was updated successfully, but these errors were encountered:

ljharb · 2016-07-18T00:08:00Z

That seems good to me.

This has been deprecated for a while. We have decided to remove it entirely for 6.0.0 (jsx-eslint#686). Fixes jsx-eslint#549.

This rule is JSX-specific, not React-specific. Changing its name makes this clearer. I've kept the old one around as deprecated. We can remove it at the next major version bump. Addresses jsx-eslint#668 and jsx-eslint#686.

This rule is JSX-specific, not React-specific. Changing its name makes this clearer. I've kept the old one around as deprecated. We can remove it at the next major version bump. Addresses jsx-eslint#686. Fixes jsx-eslint#668.

This rule is JSX-specific, not React-specific. Changing its name makes this clearer. I've kept the old one around as deprecated. We can remove it at the next major version bump. Addresses jsx-eslint#668 and jsx-eslint#686.

This rule is JSX-specific, not React-specific. Changing its name makes this clearer. I've kept the old one around as deprecated. We can remove it at the next major version bump. Addresses jsx-eslint#686. Fixes jsx-eslint#668.

ljharb · 2016-07-22T04:52:58Z

5 down, 4 to go!

lencioni · 2016-07-23T19:48:24Z

On this roadmap, you have

Enable allow-in-func mode by default in no-did-mount-set-state and no-did-update-set-state rules

I'm not entirely sure what you want done here? Does this amount to removing the option and just having it always be the case, or should this be the case by default and there would be a new option like disallow-in-func?

yannickcr · 2016-07-23T23:58:11Z

should this be the case by default and there would be a new option like disallow-in-func

I was more thinking about something like this.

ljharb · 2016-07-25T21:06:43Z

It looks like the last 3 issues all have PRs up - how quickly do you think we could get to a v6?

yannickcr · 2016-07-25T21:36:56Z

@ljharb I hope to publish an RC before friday and the final this week-end if there is no major issue.

ljharb · 2016-07-27T22:09:10Z

@yannickcr there's still one unchecked item on the list - is that punted to v7?

petersendidit · 2016-07-27T22:11:30Z

I just rebased #699 so it should be able to be merged cleanly.

yannickcr · 2016-07-27T22:19:08Z

@ljharb no, still planned for v6 :)

ljharb · 2016-07-27T22:24:10Z

Should this be reopened until that's merged?

yannickcr · 2016-07-27T22:26:54Z

Yep

ljharb · 2016-07-29T07:21:21Z

@yannickcr any more things to add to the above checklist, or are we good for a final release? :-)

yannickcr · 2016-07-29T18:00:32Z

Still a few changes and I think I'll be good to push an RC in the coming hours.

yannickcr · 2016-07-29T19:31:46Z

v6.0.0-rc.0 is now published on npm.

You can install it with npm install eslint-plugin-react@next

ljharb · 2016-08-01T04:22:26Z

I see rc.1 is out. Is there a planned time to release v6?

nwhitmont · 2016-08-01T18:57:57Z

What's the timeline on v6.0.0 release? Appears to be blocking airbnb eslint config installation --airbnb/javascript#936

yannickcr · 2016-08-01T19:06:35Z

@ljharb @nwhitmont v6.0.0 should be released in the coming hours.

yannickcr · 2016-08-01T19:52:21Z

v6.0.0 is now published on npm

lencioni · 2016-08-01T21:18:44Z

Thanks for all of your hard work on this plugin @yannickcr! This plugin has greatly helped me and my teams over the past couple of years, and I just wanted to make sure you feel appreciated for the effort you put in here. This is such an valuable tool that you've built. 👏 👏 👏

Thinking ahead to future major version bumps, I'm wondering--is there anything that I (or others who are interested) can do to help make sure that things continue to run smoothly? I don't want you to feel like you are running this thing all by yourself.

nwhitmont · 2016-08-01T22:15:34Z

Thank you @yannickcr !

yannickcr · 2016-08-02T00:00:55Z

Thank you all for your support 😍 , and thanks for your contributions @lencioni 😃

Thinking ahead to future major version bumps, I'm wondering--is there anything that I (or others who are interested) can do to help make sure that things continue to run smoothly? I don't want you to feel like you are running this thing all by yourself.

Well, there is more and more open issues and PRs to review/validate and I have some difficulties to keep up with all of this. I added @ljharb as a contributor a few months ago and he made a really great work on issues triage, PRs validation and responding to users questions ❤️ . So I'm now thinking about adding more people as contributors.

Would you be interested to be added as contributor @lencioni?

ljharb · 2016-08-02T00:37:31Z

I'm biased because I work with @lencioni, but I highly endorse his being added!

lencioni · 2016-08-02T03:24:05Z

Would you be interested to be added as contributor @lencioni?

Sure!

yannickcr · 2016-08-02T07:45:14Z

Done :)

ljharb mentioned this issue Jul 18, 2016

Allow peerDependency eslint@3.0.0 airbnb/javascript#936

Closed

lukebennett mentioned this issue Jul 18, 2016

Allow peerDependency eslint-plugin-jsx-a11y@^2.0.0 airbnb/javascript#952

Closed

lencioni added a commit to lencioni/eslint-plugin-react that referenced this issue Jul 18, 2016

Remove deprecated jsx-sort-prop-types rule

c6cad0f

This has been deprecated for a while. We have decided to remove it entirely for 6.0.0 (jsx-eslint#686). Fixes jsx-eslint#549.

lencioni added a commit to lencioni/eslint-plugin-react that referenced this issue Jul 18, 2016

Remove deprecated jsx-sort-prop-types rule

98d5357

This has been deprecated for a while. We have decided to remove it entirely for 6.0.0 (jsx-eslint#686). Fixes jsx-eslint#549.

lencioni mentioned this issue Jul 18, 2016

Remove deprecated jsx-sort-prop-types rule #688

Merged

lencioni mentioned this issue Jul 18, 2016

Rename some JSX-specific rules to include jsx- prefix #689

Merged

ljharb mentioned this issue Jul 22, 2016

Switch to new eslint rule format (Fixes #661) #699

Merged

lencioni mentioned this issue Jul 23, 2016

Remove rules deprecated options #700

Merged

lencioni mentioned this issue Jul 24, 2016

Enable allow-in-func mode by default in no-did-mount-set-state and no-did-update-set-state rules #702

Merged

michael-martin mentioned this issue Jul 26, 2016

Add Airbnb ESLint Config DeloitteDigitalUK/react-redux-starter-app#1

Closed

yannickcr closed this as completed in 376dc53 Jul 27, 2016

yannickcr reopened this Jul 27, 2016

yannickcr closed this as completed Aug 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Roadmap v6.0.0 #686

Roadmap v6.0.0 #686

yannickcr commented Jul 17, 2016 •

edited

Loading

ljharb commented Jul 18, 2016

ljharb commented Jul 22, 2016

lencioni commented Jul 23, 2016

yannickcr commented Jul 23, 2016

ljharb commented Jul 25, 2016

yannickcr commented Jul 25, 2016

ljharb commented Jul 27, 2016

petersendidit commented Jul 27, 2016

yannickcr commented Jul 27, 2016

ljharb commented Jul 27, 2016

yannickcr commented Jul 27, 2016

ljharb commented Jul 29, 2016

yannickcr commented Jul 29, 2016

yannickcr commented Jul 29, 2016 •

edited by ljharb

Loading

ljharb commented Aug 1, 2016

nwhitmont commented Aug 1, 2016 •

edited

Loading

yannickcr commented Aug 1, 2016

yannickcr commented Aug 1, 2016

lencioni commented Aug 1, 2016

nwhitmont commented Aug 1, 2016

yannickcr commented Aug 2, 2016

ljharb commented Aug 2, 2016

lencioni commented Aug 2, 2016

yannickcr commented Aug 2, 2016

Roadmap v6.0.0 #686

Roadmap v6.0.0 #686

Comments

yannickcr commented Jul 17, 2016 • edited Loading

ljharb commented Jul 18, 2016

ljharb commented Jul 22, 2016

lencioni commented Jul 23, 2016

yannickcr commented Jul 23, 2016

ljharb commented Jul 25, 2016

yannickcr commented Jul 25, 2016

ljharb commented Jul 27, 2016

petersendidit commented Jul 27, 2016

yannickcr commented Jul 27, 2016

ljharb commented Jul 27, 2016

yannickcr commented Jul 27, 2016

ljharb commented Jul 29, 2016

yannickcr commented Jul 29, 2016

yannickcr commented Jul 29, 2016 • edited by ljharb Loading

ljharb commented Aug 1, 2016

nwhitmont commented Aug 1, 2016 • edited Loading

yannickcr commented Aug 1, 2016

yannickcr commented Aug 1, 2016

lencioni commented Aug 1, 2016

nwhitmont commented Aug 1, 2016

yannickcr commented Aug 2, 2016

ljharb commented Aug 2, 2016

lencioni commented Aug 2, 2016

yannickcr commented Aug 2, 2016

yannickcr commented Jul 17, 2016 •

edited

Loading

yannickcr commented Jul 29, 2016 •

edited by ljharb

Loading

nwhitmont commented Aug 1, 2016 •

edited

Loading