Rule proposal: disallow children prop #720
Labels
Comments
benstepp
added a commit
to benstepp/eslint-plugin-react
that referenced
this issue
Jul 27, 2016
Prevents children being passed as props. Children should be actual children.
benstepp
added a commit
to benstepp/eslint-plugin-react
that referenced
this issue
Jul 27, 2016
Prevents children being passed as props. Children should be actual children.
benstepp
added a commit
to benstepp/eslint-plugin-react
that referenced
this issue
Jul 27, 2016
Prevents children being passed as props. Children should be actual children. * Add Component to tests for no-children-prop * Add note in docs about recommended behavior * Change syntax in docs for no-children-prop to jsx
benstepp
added a commit
to benstepp/eslint-plugin-react
that referenced
this issue
Jul 27, 2016
Prevents children being passed as props. Children should be actual children. --- * Add Component to tests for no-children-prop * Add note in docs about recommended behavior * Change syntax in docs for no-children-prop to jsx --- * Clarify that multiple arguments may be passed as children to React.createElement * Reorganize tests to show JSX with createElement counterpart immediately following. * Added test cases with a non-children property * Added test cases with multiple children
benstepp
added a commit
to benstepp/eslint-plugin-react
that referenced
this issue
Jul 27, 2016
Prevents children being passed as props. Children should be actual children. --- * Add Component to tests for no-children-prop * Add note in docs about recommended behavior * Change syntax in docs for no-children-prop to jsx --- * Clarify that multiple arguments may be passed as children to React.createElement * Reorganize tests to show JSX with createElement counterpart immediately following. * Added test cases with a non-children property * Added test cases with multiple children --- * Add no-children-prop to recommended config
benstepp
added a commit
to benstepp/eslint-plugin-react
that referenced
this issue
Sep 16, 2016
Prevents children being passed as props. Children should be actual children. --- * Add Component to tests for no-children-prop * Add note in docs about recommended behavior * Change syntax in docs for no-children-prop to jsx --- * Clarify that multiple arguments may be passed as children to React.createElement * Reorganize tests to show JSX with createElement counterpart immediately following. * Added test cases with a non-children property * Added test cases with multiple children --- * Add no-children-prop to recommended config
benstepp
added a commit
to benstepp/eslint-plugin-react
that referenced
this issue
Sep 16, 2016
Prevents children being passed as props. Children should be actual children. --- * Add Component to tests for no-children-prop * Add note in docs about recommended behavior * Change syntax in docs for no-children-prop to jsx --- * Clarify that multiple arguments may be passed as children to React.createElement * Reorganize tests to show JSX with createElement counterpart immediately following. * Added test cases with a non-children property * Added test cases with multiple children --- * Add no-children-prop to recommended config
benstepp
added a commit
to benstepp/eslint-plugin-react
that referenced
this issue
Sep 16, 2016
Prevents children being passed as props. Children should be actual children. --- * Add Component to tests for no-children-prop * Add note in docs about recommended behavior * Change syntax in docs for no-children-prop to jsx --- * Clarify that multiple arguments may be passed as children to React.createElement * Reorganize tests to show JSX with createElement counterpart immediately following. * Added test cases with a non-children property * Added test cases with multiple children --- * Add no-children-prop to recommended config --- * Remove recommended config for no-children-prop
benstepp
added a commit
to benstepp/eslint-plugin-react
that referenced
this issue
Sep 16, 2016
Prevents children being passed as props. Children should be actual children. --- * Add Component to tests for no-children-prop * Add note in docs about recommended behavior * Change syntax in docs for no-children-prop to jsx --- * Clarify that multiple arguments may be passed as children to React.createElement * Reorganize tests to show JSX with createElement counterpart immediately following. * Added test cases with a non-children property * Added test cases with multiple children --- * Add no-children-prop to recommended config --- * Remove recommended config for no-children-prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Children should always be actual children, not passed in as a prop.
Bad:
Good:
This should also apply to
React.createElement.Name:
no-children-prop?The text was updated successfully, but these errors were encountered: