Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alignment bug in jsx-indent (and extract duplicate code) #1539

Merged
merged 4 commits into from
Nov 18, 2017
Merged

Fix alignment bug in jsx-indent (and extract duplicate code) #1539

merged 4 commits into from
Nov 18, 2017

Commits on Nov 16, 2017

  1. Add failing test

    @jseminck
    jseminck committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    8f3dc55 View commit details
    Browse the repository at this point in the history

  2. Fix test by using the same isNodeFirstInLine function found in jsx-cl… 

    …osing-tag-location rule
    @jseminck
    jseminck committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    6d50fb6 View commit details
    Browse the repository at this point in the history

  3. Extract isNodeFirstInLine to astUtil function

    @jseminck
    jseminck committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    c51087c View commit details
    Browse the repository at this point in the history

  4. Use the new function also in jsx-indent-props 

    Although the logic is quite different here, the new function seems to work (tests are passing)
    @jseminck
    jseminck committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    acc4f24 View commit details
    Browse the repository at this point in the history