Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] no-render-return-value: reuse version test result #2264

Merged
merged 2 commits into from
May 6, 2019
Merged

[Refactor] no-render-return-value: reuse version test result #2264

merged 2 commits into from
May 6, 2019

Conversation

golopot
Copy link
Contributor

@golopot golopot commented May 6, 2019

This commit likely fixes the performace issue noted in #2259.

ljharb
ljharb approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great improvement.

@ljharb ljharb force-pushed the refactor-no-render-return-value branch from 2fc4c80 to a7c48dd Compare May 6, 2019 18:24
@ljharb ljharb merged commit a7c48dd into jsx-eslint:master May 6, 2019
@golopot golopot deleted the refactor-no-render-return-value branch May 10, 2019 22:36
@yannickcr yannickcr mentioned this pull request Jun 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@golopot @ljharb