Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] hook-use-state: add allowDestructuredState option #3449

Merged

Conversation

metreniuk
Copy link
Contributor

This PR fixes #3443 by adding a new option to the rule.
I want to be sure that I'm on the right path, so I could add fixes later.

@metreniuk metreniuk force-pushed the add-allow-destructuring-for-hook-use-state branch from 19ec70e to fa72d87 Compare October 4, 2022 20:21
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #3449 (96062ea) into master (96062ea) will not change coverage.
The diff coverage is n/a.

❗ Current head 96062ea differs from pull request most recent head c3d3e25. Consider uploading reports for the commit c3d3e25 to get more accurate results

@@           Coverage Diff           @@
##           master    #3449   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files         123      123           
  Lines        8978     8978           
  Branches     3282     3282           
=======================================
  Hits         8765     8765           
  Misses        213      213           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When viewing the diff ignoring whitespace changes, it looks great - nice and simple. Thanks!

@metreniuk metreniuk force-pushed the add-allow-destructuring-for-hook-use-state branch from fa72d87 to 54f0f84 Compare October 9, 2022 09:41
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to hold off on landing semver-minor things until after I've cut the next patch release, but hopefully that won't be long.

@ljharb ljharb force-pushed the add-allow-destructuring-for-hook-use-state branch from 54f0f84 to a258d1d Compare October 9, 2022 17:08
@ljharb ljharb changed the title Add allow destructuring for hook use state [New] hook-use-state: add allowDestructuredState option Oct 9, 2022
@ljharb ljharb force-pushed the add-allow-destructuring-for-hook-use-state branch from a258d1d to c3d3e25 Compare October 9, 2022 20:22
@ljharb ljharb merged commit c3d3e25 into jsx-eslint:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Allow nested destructuring with react/hook-use-state
2 participants