Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] jsx-filename-extension: add ignoreFilesWithoutCode option to allow empty files #3674

Merged
merged 1 commit into from
Jan 10, 2024
Merged

[New] jsx-filename-extension: add ignoreFilesWithoutCode option to allow empty files #3674

merged 1 commit into from
Jan 10, 2024

Conversation

burtek
Copy link
Contributor

@burtek burtek commented Jan 9, 2024

Fixes #3644

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca162fd) 97.65% compared to head (fe4cf07) 97.65%.

❗ Current head fe4cf07 differs from pull request most recent head 2e30897. Consider uploading reports for the commit 2e30897 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3674   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         132      132           
  Lines        9379     9383    +4     
  Branches     3433     3436    +3     
=======================================
+ Hits         9159     9163    +4     
  Misses        220      220

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burtek

This comment was marked as resolved.

Sign in to view
ljharb
ljharb approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

lib/rules/jsx-filename-extension.js Show resolved Hide resolved
@ljharb ljharb changed the title [jsx-filename-extension]: option to allow empty files [New] jsx-filename-extension: add ignoreFilesWithoutCode option to allow empty files Jan 10, 2024
@ljharb ljharb force-pushed the jsx-filename-extension branch from fe4cf07 to 2e30897 Compare January 10, 2024 18:26
@ljharb ljharb merged commit 2e30897 into jsx-eslint:master Jan 10, 2024
309 checks passed
@burtek burtek deleted the jsx-filename-extension branch January 10, 2024 22:08
@BuloZB BuloZB mentioned this pull request May 19, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request May 24, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
Open
@mjperrins mjperrins mentioned this pull request May 30, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Jun 3, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Jun 3, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Jun 3, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Jun 3, 2024
Open
This was referenced Jun 3, 2024
Open
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Jun 4, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jun 5, 2024
Open
@cezaraugusto cezaraugusto mentioned this pull request Jun 6, 2024
Merged
@paaschdigital paaschdigital mentioned this pull request Jun 7, 2024
Open
@MANAALHARBI MANAALHARBI mentioned this pull request Jun 8, 2024
Merged
@richyhoopd richyhoopd mentioned this pull request Jun 18, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jun 18, 2024
Open
This was referenced Jun 18, 2024
Open
Open
This was referenced Oct 3, 2024
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@scatools-demo scatools-demo mentioned this pull request Oct 3, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Oct 4, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 4, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Oct 4, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 4, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@scatools-demo scatools-demo mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 4, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 6, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 6, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 16, 2024
Open
@MANAALHARBI MANAALHARBI mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[jsx-filename-extension]: option to allow empty files
2 participants
@burtek @ljharb