-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] version settings: Allow react defaultVersion to be configurable #3771
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3771 +/- ##
==========================================
+ Coverage 97.62% 97.76% +0.13%
==========================================
Files 134 134
Lines 9617 9644 +27
Branches 3488 3497 +9
==========================================
+ Hits 9389 9428 +39
+ Misses 228 216 -12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty solid, thanks. I'm going to hold off on merging semver-minor PRs for a bit, but I'll make sure to get to it before i make the next release.
380e32c
to
51d342b
Compare
418374f
to
00b89fe
Compare
I have some projects where I want to detect the react version most of the time, but sometimes I expect that to fail. In those cases, I don't want to default to "latest". I instead want to choose the default fallback version of React.